[Assignment 1 - DB] Nguyen Le Thien An#2
Open
AnNguyenLe wants to merge 1 commit intoEngineerProOrg:database-assignment-1from
Open
[Assignment 1 - DB] Nguyen Le Thien An#2AnNguyenLe wants to merge 1 commit intoEngineerProOrg:database-assignment-1from
AnNguyenLe wants to merge 1 commit intoEngineerProOrg:database-assignment-1from
Conversation
tpdongcs
reviewed
Oct 5, 2023
|
|
||
| -- điểm số trung bình của các course (quy ra lại theo chữ cái) | ||
| select t.course_id, t.course_name, | ||
| case when t.avg_grade_num = 10 then 'A' |
Collaborator
There was a problem hiding this comment.
should use >= , <= ... because avg may return float number
| -- những course (distinct) mà 1 professor cụ thể đang dạy | ||
| select distinct c.course_id, c.course_name, p.prof_id, p.prof_fname, p.prof_lname | ||
| from professor as p join class as cl on p.prof_id = cl.prof_id | ||
| join course as c on cl.course_id = c.course_id; |
Collaborator
There was a problem hiding this comment.
this question meaning that, we already have prof_id, and find all distinct course that he teach
| prof_id int not null, | ||
| prof_lname varchar(50), | ||
| prof_fname varchar(50), | ||
| primary key (prof_id) |
Collaborator
There was a problem hiding this comment.
should add auto increase primary id ( and for all tables too)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.